Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP] Add loadbalancing ingest pipeline #4350

Merged
merged 4 commits into from
Oct 4, 2022
Merged

[GCP] Add loadbalancing ingest pipeline #4350

merged 4 commits into from
Oct 4, 2022

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Sep 29, 2022 •
edited by endorama
Loading

What does this PR do?

Adds loadbalancing_metrics ingest pipeline.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 force-pushed the add_gcp-loadbalancing_ingest-pipeline branch from 9dffaa5 to 0f61fb1 Compare September 29, 2022 16:40
@elasticmachine
Copy link

elasticmachine commented Sep 29, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-04T07:47:47.526+0000

  • Duration: 18 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 82
Skipped 0
Total 82

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@gpop63 gpop63 self-assigned this Sep 29, 2022
@elasticmachine
Copy link

elasticmachine commented Sep 29, 2022 •
edited
Loading

🚀 Benchmarks report

Package gcp 👍(2) 💚(0) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
dns 3021.15 1855.29 -1165.86 (-38.59%) 💔
firewall 3086.42 1968.5 -1117.92 (-36.22%) 💔
vpcflow 4694.84 2105.26 -2589.58 (-55.16%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Sep 29, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.787
Classes 100.0% (5/5) 💚 2.787
Methods 90.816% (89/98) 👍 1.134
Lines 95.752% (1375/1436) 👍 4.226
Conditionals 100.0% (0/0) 💚

@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Sep 30, 2022
@endorama endorama mentioned this pull request Sep 30, 2022
Closed
@endorama endorama marked this pull request as ready for review September 30, 2022 15:02
@endorama endorama requested review from a team as code owners September 30, 2022 15:02
@endorama endorama merged commit d02b647 into elastic:main Oct 4, 2022
@andrewkroh andrewkroh mentioned this pull request Oct 4, 2022
Merged
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@gpop63 gpop63

Labels
Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gpop63 @elasticmachine @kaiyan-sheng @endorama